Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 5 Current »

When you create a pull request, consider the following:

Bug or Feature Description

If it's a bug, how does it affect a customer? 
If it's a feature, why do we need it?

Description of Your Change

If it's a bug, how did you fix it?
If it's a feature, what does it do?

Link to Design

If there is an external design, add a link to it.  (The design should include a link to the discussion on the Forum)

Testing Logs or Output

Please attach your test log output from running the test you added (or from existing tests that cover your changes)

Optional Considerations


StepRequired for a feature?Required for a bug?
Code follows coding styleRequiredRequired
Design document in project documentation areaRequiredHelpful for complex bugs
Added PTL tests, or, if necessary, manual testsRequiredRequired
Added test output/logs

Checked for memory leaks

Join the pbspro community forumOptionalOptional
Sign the CLA

Pull request consists of a single commit

Commit is up to dateWhenever possibleWhenever possible
Git ticket filedOptionalOptional
Code is signed off by at least one maintainer, and another contributorRequiredRequired
Code header contains license textRequiredRequired
PTL test header created by developer contains license text
RequiredRequired

  • No labels