Page Comparison

One of the following commands is present in the %post section:

cp, mv, ln, tar, rpm, chmod, chown, rm, cpio, install, perl, userdel, groupdel

One of the following commands is present in the %post section:

cp, mv, ln, tar, rpm, chmod, chown, rm, cpio, install, perl, userdel, groupdel

The tool /usr/lib/rpm/redhat/brp-compress is responsible for compressing online man pages as part of the build and package. The tool does not take the prefix into account when it is run and does not look for man pages under /opt. Commands must be added in the %install section to simulate this behavior. When packing for Linux vendor repositories, brp-compress will work as expected. The following code should be added after %make_install in pbspro.spec.in and pbspro.spec:

mandir=$(find %{buildroot} -type d -name man)
[ -d "$mandir" ] && find $mandir -type f -exec gzip -9 -n {} \;

The %changelog section in the spec file normally appears at the very end. It is not intended to capture all changes to PBS Pro, but only changes the spec file itself. None of the spec files in OpenHPC (and there are several) have a %changelog section. In fact, the TravisCI script they use prohibits one from being present. The %changelog section should resemble the following, listing the changes in descending order (from the most recent one first), and also choosing an arbitrary <revision number> for example, "1.1":

%changelog
- Removed dangerous commands in %post section
* Fri Nov 9 2018 Michael Karo <mkaro@altair.com> - <revision number>
- Removed dangerous commands in %post section
- Note 1
- Note 2
* Thu Nov 8 2018 Michael Karo <mkaro@altair.com> - <revision number>
- Update version to 19.1.1

The README and LICENSE files should be packaged at the minimum. The man pages should also be tagged with %doc. The %files section for each package should be updated accordingly. An administrator may use the --excludedocs flag to prevent installation of the online man pages. The following lines will need to be added for each package:

%dir %{pbs_prefix}/share/doc/%{name}
%doc %{pbs_prefix}/share/doc/%{name}/README
%license %{pbs_prefix}/share/doc/%{name}/LICENSE

Tag files in /etc/profile.d in the %files section of the spec file for each RPM as follows:

%config(noreplace) %{_sysconfdir}/profile.d/*

The ldconfig command must be called from the %post section to create the necessary symbolic links for shared libraries. The following command should be sufficient:

ldconfig %{_libdir}

The ldconfig command must be called from the %postun section to create the necessary symbolic links for shared libraries. The following command should be sufficient:

ldconfig %{_libdir}

This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.

The file is setuid; this may be dangerous, especially if this file is setuid root. Sometimes file capabilities can be used instead of setuid bits.

This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation.