| Step | Required for a feature? | Required for a bug? |
|---|
| Code follows coding style |
|
|
| External Design Document | Required | Helpful for complex bugs |
| Added PTL tests, or, if necessary, manual tests | Required | Required |
| Added test output/logs |
|
|
| Checked for memory leaks |
|
|
| Join the pbspro community forum | Optional | Optional |
| Sign the CLA |
|
|
| Sign commits | Optional | Optional |
| Pull request consists of a single commit |
|
|
| Commit is up to date | Whenever possible | Whenever possible |
| Git ticket filed | Optional | Optional |
| Evidence that manual or automated tests created by the developer were performed | Required | Required |
| Automated PTL tests created by the developer are signed off by at least one maintainer, and another contributor | Required when the test case can be automated. Some automated test cases may require specialized configurations. | Required with some exceptions for test cases that cannot be automated, including: - problems that can only be seen with tools such as valgrind
Some automated test cases may require specialized configurations. |
| Code is signed off by at least one maintainer, and another contributor | Required | Required |
| Code header contains license text | Required | Required |
PTL test header created by developer contains license text
| Required | Required |